-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix temp object out of scope issue (#8767) #8829
Fix temp object out of scope issue (#8767) #8829
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: yibin <huyibin@pingcap.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xzhangxian1008, yibin87 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/run-all-tests |
This is an automated cherry-pick of #8767
What problem does this PR solve?
Issue Number: close #8674
Problem Summary:
When encode enum column, we get the enum name from DataTypeEnum's getNameForValue. However, the return value is a temporary object, and its life scope is limited by the construction of TiDBEnum:
https://github.com/pingcap/tiflash/blob/b9468ccfaa0da1e004b36acfb081b3da4ff2d07e/dbms/src/Flash/Coprocessor/ArrowColCodec.cpp#L350C1-L352C99,
And the name field in TiDBEnum is a constant reference also, which points to the temporary object.
Confirmed this root cause by two steps:
Still not sure why v7.5.0 is not affected by this issue, debug version seems not affected by the issue either.
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note